Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
RegEx
on Aug 24, 2012
|
parent
|
context
|
favorite
| on:
Why I am tired of writing pull requests
Completely forgivable. This pull request[0], on the other hand, is probably more along the lines of what mirsadm was thinking of.
[0]:
https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...
masklinn
on Aug 24, 2012
|
next
[–]
That's the douchiest diff I've seen yet. I've seen diffs where a shitty and misconfigured IDE had reformatted half the code and the guy hadn't reviewed his diff, but "incidentally spaces to tab" is the biggest "fuck you reviewer" I can think of.
aaronsw
on Aug 24, 2012
|
prev
[–]
https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...
people.
RegEx
on Aug 24, 2012
|
parent
[–]
I have no clue where that commit is coming from. How do I get to it? Thanks.
tedunangst
on Aug 24, 2012
|
root
|
parent
|
next
[–]
It's the same commit you linked to, but ignoring whitespace changes (&w=1, like diff -w).
RegEx
on Aug 24, 2012
|
root
|
parent
|
prev
[–]
Apparently the parameter w=1 fixes the white space for the diff in the browser. Is there a way to make the pull request reference that?
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search:
[0]: https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...