Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Code review generally requires a peer to do the reviewing, so most folks would likely say that doesn’t count. I was curious if it would, but the first couple pages of googled results confirm the peer aspect.


That's certainly better than reviewing your own code, but tossing your code into a merge request to run tests and then taking another look over it tomorrow if it's all green is still better than just pushing straight to prod because there's not another pair of eyes.


> but tossing your code into a merge request to run tests and then taking another look over it tomorrow

Or even just immediately. I often find minor issues just by looking at it in a different context (the merge request vs my editor).


Naturally. That’s a different process from a code review though, which is what this thread is discussing.


It's the same process as code review. It is code review.


Agree to disagree then, per wikipedia and several other sources that pop up when googling.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: